Comskip Support Forum

Comskip is a free commercial detector, browse the forum for more information
It is currently Thu Nov 23, 2017 5:33 pm

All times are UTC [ DST ]




Post new topic Reply to topic  [ 15 posts ] 
Author Message
PostPosted: Sat Mar 04, 2017 7:42 pm 
Offline

Joined: Sat Mar 04, 2017 7:33 pm
Posts: 7
When analyzing mkv files created with Plex DVR and HDHomeRun Prime (not copy protected, US broadcast channels) donator's versions81_93 and 81_94 no longer output srt files from the closed captioning information. It works fine in version 81_92_donators.

If you need sample video files, let me know.


Top
 Profile  
Reply with quote  
PostPosted: Wed Apr 19, 2017 9:38 pm 
Offline

Joined: Fri Oct 25, 2013 6:39 am
Posts: 10
https://github.com/erikkaashoek/Comskip/commit/60ed99d080f160164d538051e53310028998444e

that commit ended up changing the output name of the srt file to smi


Top
 Profile  
Reply with quote  
PostPosted: Tue Apr 25, 2017 8:46 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3098
Corrected
Should be ok now in build 95


Top
 Profile  
Reply with quote  
PostPosted: Sat May 13, 2017 7:48 pm 
Offline

Joined: Sat Mar 04, 2017 7:33 pm
Posts: 7
Thanks for looking into it. I tried build 97 and it does output srt files again.

The problem now is it never outputs more than 3 minutes worth of subtitles. In the SRT file, they stop usually between 50 seconds and 3 minutes into the show. EDL files seem to work normally still, so it is still scanning the whole file.

Thanks.


Top
 Profile  
Reply with quote  
PostPosted: Sun May 14, 2017 12:30 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3098
Probably stops after finding logo.
Can you check?


Top
 Profile  
Reply with quote  
PostPosted: Sun May 14, 2017 5:29 pm 
Offline

Joined: Sat Mar 04, 2017 7:33 pm
Posts: 7
That does appear to be what's happening.
Here's a OneDrive url to the log and srt file of an example recording scan:
https://1drv.ms/f/s!AvNhAUP7bUAto5ZzTr8BpqCnyBHeIw
It is valid for 30 days.


Top
 Profile  
Reply with quote  
PostPosted: Mon May 15, 2017 5:14 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3098
Thanks


Top
 Profile  
Reply with quote  
PostPosted: Mon May 15, 2017 11:32 pm 
Offline

Joined: Fri Oct 25, 2013 6:39 am
Posts: 10
I don't know why it works, but doing this fixes the problem for me on Win XP.

Code:
@@ -9355,7 +9355,7 @@ FILE* LoadSettings(int argc, char ** argv)
     if (!loadingTXT && (output_srt || output_smi ))
     {
 #ifdef PROCESS_CC
-        char filename[MAX_PATH];
+        //char filename[MAX_PATH];
         char *CEW_argv[10];
         i = 0;
         CEW_argv[i++] = "comskip.exe";


Top
 Profile  
Reply with quote  
PostPosted: Thu Aug 03, 2017 2:02 am 
Offline

Joined: Sat Mar 04, 2017 7:33 pm
Posts: 7
Any news on this? I'm excited to try a newer version.

Thanks for all your hard work.


Top
 Profile  
Reply with quote  
PostPosted: Thu Aug 03, 2017 12:20 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3098
I was assuming it was fixed. Its not?


Top
 Profile  
Reply with quote  
PostPosted: Sat Aug 05, 2017 8:43 pm 
Offline

Joined: Sat Mar 04, 2017 7:33 pm
Posts: 7
No, it stops processing subtitles when it finds the logo.


Top
 Profile  
Reply with quote  
PostPosted: Mon Aug 07, 2017 7:25 am 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3098
Will look into it


Top
 Profile  
Reply with quote  
PostPosted: Tue Aug 08, 2017 2:17 am 
Offline

Joined: Sat Mar 04, 2017 7:33 pm
Posts: 7
Thanks! If you need a sample recording / comskip.ini, or any other files, let me know.


Top
 Profile  
Reply with quote  
PostPosted: Sat Aug 12, 2017 12:21 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3098
Found the problem and will be solved in the next release 0.82.001, later today


Top
 Profile  
Reply with quote  
PostPosted: Tue Aug 15, 2017 1:02 am 
Offline

Joined: Sat Mar 04, 2017 7:33 pm
Posts: 7
I have confirmed srt output works as expected now. Thanks for all the work you do on this - I appreciate it.


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 15 posts ] 

All times are UTC [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group