While trying to improve my comskip tuning I've come across what looks like an issue with the averages for each block. Here's a screenshot of the graphs showing 4 blocks.
Looking at the brightness at the bottom to begin with, the first two white lines look roughly correct, but the next green line is way too high compared to the red values behind it.
The values from the log match the lines drawn.
Code: Select all
5:-- 1 1 0 30357 32108 1.50 70.040 0.19 0 1.26 N b 1453+ 0.08 1265+ 95- 0.000 145
6:-- 2 1 1 32109 33109 3.00 40.000 0.14 0 1.26 L N b 1617+ 0.00 1054- 95- 0.000 161
7:++ 3 1 2 33110 44913 0.01 472.120 0.32 0 1.26 EL b 1966+ 0.90 1204+ 980 0.000 196
8:++ 3 2 1 44914 48414 1.00 140.000 0.13 0 1.26 b 975- 0.11 940- 94- 0.000 97
I loaded up the csv file in excel and calculated the average brightness for each block and came up with 109, 136, 71, 102 which looks like what I would have expected.
Graphing these values looks to give a far better indication of the brightness of each block.
Out of curiousity I had a look in the source code and noticed this
Code: Select all
// b = frame[k].brightness;
b = abs(frame[k].brightness - frame[k-1].brightness);
Can the average brightness calculation be changed back to be a true average?
Moving on to the other graphs. The Uniformity and Scene_change averages appear to have the same problem as brightness. I graphed the averages in excel and it showed that the 3rd block should have lower values than the 1st 2nd and 4th, but as you can see in the screenshot above comskip has the 3rd block marked as the highest value and punishes them accordingly.
The Sound graph appears to be showing the averages all at or close to 0. The values in the log file block list are correct and match what I calculated in excel so I think this might be just a drawing issue.
Are these issues you can fix?
cheers,
nate