Comskip Support Forum

Comskip is a free commercial detector, browse the forum for more information
It is currently Mon Jul 23, 2018 6:38 pm

All times are UTC [ DST ]




Post new topic Reply to topic  [ 14 posts ] 
Author Message
PostPosted: Mon Feb 20, 2017 8:52 am 
Offline

Joined: Mon May 10, 2010 2:44 am
Posts: 88
I've discovered that I get different results using the Frame Array file compared to scanning the file directly with no changes to comskip.ini What are the differences between the 2 modes apart from speed? As I'm using a pre found logo the full file scan uses 2 threads and the file is SD H264 / AAC-HE


Top
 Profile  
Reply with quote  
PostPosted: Mon Feb 20, 2017 9:00 am 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3190
There is a small difference that could trigger an on-the-edge condition.
can you make the recording available to me?


Top
 Profile  
Reply with quote  
PostPosted: Mon Feb 20, 2017 9:04 am 
Offline

Joined: Mon May 10, 2010 2:44 am
Posts: 88
Sure, I'll upload it in a couple of hours or so, assuming you will get chance to take a look later today? Otherwise is in about 12 hours ok?


Top
 Profile  
Reply with quote  
PostPosted: Mon Feb 20, 2017 9:22 am 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3190
Ping me when done


Top
 Profile  
Reply with quote  
PostPosted: Mon Feb 20, 2017 11:19 am 
Offline

Joined: Mon May 10, 2010 2:44 am
Posts: 88
erik wrote:
Ping me when done

I just sent you a PM with the links in.
Its the break between frames 57264 & 59745 that is missing when scanned with the full file. The actual end of the commercial is at 59890 but as there isn't any black frames I haven't found a way to trigger it at that frame.


Top
 Profile  
Reply with quote  
PostPosted: Mon Feb 20, 2017 12:15 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3190
Very helpfull recording. Need to find the root cause of the differences.


Top
 Profile  
Reply with quote  
PostPosted: Mon Feb 20, 2017 7:48 pm 
Offline

Joined: Mon May 10, 2010 2:44 am
Posts: 88
Glad you can reproduce it.
Whilst I was waiting for the upload to finish I tested dropping it down to 1 thread in case that was the cause but it made no difference.


Top
 Profile  
Reply with quote  
PostPosted: Tue Feb 21, 2017 4:28 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3190
The decoder can not do real mutithreading on certain h.264 recordings.


Top
 Profile  
Reply with quote  
PostPosted: Wed Feb 22, 2017 5:47 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3190
Differences between original processing and frame array based processing should be solved in next release.


Top
 Profile  
Reply with quote  
PostPosted: Wed Feb 22, 2017 7:10 pm 
Offline

Joined: Mon May 10, 2010 2:44 am
Posts: 88
Thanks!


Top
 Profile  
Reply with quote  
PostPosted: Thu Feb 23, 2017 8:44 am 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3190
Release done, can you test. I also added some error messages for wrong string parameters and cutscenefiles not found


Top
 Profile  
Reply with quote  
PostPosted: Thu Feb 23, 2017 8:50 am 
Offline

Joined: Mon May 10, 2010 2:44 am
Posts: 88
I'll give it a test tomorrow, I worked around it by adding 2 secs to shrink logo. Fortunately using a pre found logo gave me 2 threads for the full single pass scan, so I tested everything with a normal scan


Top
 Profile  
Reply with quote  
PostPosted: Fri Feb 24, 2017 4:39 am 
Offline

Joined: Mon May 10, 2010 2:44 am
Posts: 88
erik wrote:
Release done, can you test. I also added some error messages for wrong string parameters and cutscenefiles not found

I've tested it on the file that I uploaded to you, and the next in the series and it has fixed the problem, the results of both a full scan and a csv scan differ by no more than 4 frames on some of the cuts, and none on others.
On my problem channel I still get differing results, this channel has very sloppy editing, with sometimes late logos, intermittent similar to normal logos during ads, no blackframes, no guaranteed silence, and similar uniformity between show and adverts. Fortunately we don't watch a lot of that, and the fast forward button works regardless of what they do! :lol:
If I find something that's has a reproducible significant difference between FrameArray and Full Snan, I'll upload a copy.
For now I'd call it a great improvement, and for most people its likely totally fixed.
Haven't tested the cutframes yet as other methods are working.
I'll deploy the latest release now to the recorder, thanks for the prompt fix


Top
 Profile  
Reply with quote  
PostPosted: Fri Feb 24, 2017 1:06 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 3190
There is indeed a small difference in logo processing I still need to solve.


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 14 posts ] 

All times are UTC [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group