Comskip Support Forum
http://www.kaashoek.com/comskip/

81_93_donators and newer srt output broken
http://www.kaashoek.com/comskip/viewtopic.php?f=3&t=1790
Page 1 of 1

Author:  dp250f [ Sat Mar 04, 2017 7:42 pm ]
Post subject:  81_93_donators and newer srt output broken

When analyzing mkv files created with Plex DVR and HDHomeRun Prime (not copy protected, US broadcast channels) donator's versions81_93 and 81_94 no longer output srt files from the closed captioning information. It works fine in version 81_92_donators.

If you need sample video files, let me know.

Author:  McGuyver [ Wed Apr 19, 2017 9:38 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

https://github.com/erikkaashoek/Comskip/commit/60ed99d080f160164d538051e53310028998444e

that commit ended up changing the output name of the srt file to smi

Author:  erik [ Tue Apr 25, 2017 8:46 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

Corrected
Should be ok now in build 95

Author:  dp250f [ Sat May 13, 2017 7:48 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

Thanks for looking into it. I tried build 97 and it does output srt files again.

The problem now is it never outputs more than 3 minutes worth of subtitles. In the SRT file, they stop usually between 50 seconds and 3 minutes into the show. EDL files seem to work normally still, so it is still scanning the whole file.

Thanks.

Author:  erik [ Sun May 14, 2017 12:30 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

Probably stops after finding logo.
Can you check?

Author:  dp250f [ Sun May 14, 2017 5:29 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

That does appear to be what's happening.
Here's a OneDrive url to the log and srt file of an example recording scan:
https://1drv.ms/f/s!AvNhAUP7bUAto5ZzTr8BpqCnyBHeIw
It is valid for 30 days.

Author:  erik [ Mon May 15, 2017 5:14 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

Thanks

Author:  McGuyver [ Mon May 15, 2017 11:32 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

I don't know why it works, but doing this fixes the problem for me on Win XP.

Code:
@@ -9355,7 +9355,7 @@ FILE* LoadSettings(int argc, char ** argv)
     if (!loadingTXT && (output_srt || output_smi ))
     {
 #ifdef PROCESS_CC
-        char filename[MAX_PATH];
+        //char filename[MAX_PATH];
         char *CEW_argv[10];
         i = 0;
         CEW_argv[i++] = "comskip.exe";

Author:  dp250f [ Thu Aug 03, 2017 2:02 am ]
Post subject:  Re: 81_93_donators and newer srt output broken

Any news on this? I'm excited to try a newer version.

Thanks for all your hard work.

Author:  erik [ Thu Aug 03, 2017 12:20 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

I was assuming it was fixed. Its not?

Author:  dp250f [ Sat Aug 05, 2017 8:43 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

No, it stops processing subtitles when it finds the logo.

Author:  erik [ Mon Aug 07, 2017 7:25 am ]
Post subject:  Re: 81_93_donators and newer srt output broken

Will look into it

Author:  dp250f [ Tue Aug 08, 2017 2:17 am ]
Post subject:  Re: 81_93_donators and newer srt output broken

Thanks! If you need a sample recording / comskip.ini, or any other files, let me know.

Author:  erik [ Sat Aug 12, 2017 12:21 pm ]
Post subject:  Re: 81_93_donators and newer srt output broken

Found the problem and will be solved in the next release 0.82.001, later today

Author:  dp250f [ Tue Aug 15, 2017 1:02 am ]
Post subject:  Re: 81_93_donators and newer srt output broken

I have confirmed srt output works as expected now. Thanks for all the work you do on this - I appreciate it.

Page 1 of 1 All times are UTC [ DST ]
Powered by phpBB® Forum Software © phpBB Group
https://www.phpbb.com/