XML times missing first EDL time

Where all the bugs are reported and discussed
Post Reply
jason_ruz
Posts: 8
Joined: Fri Dec 22, 2006 3:34 am

XML times missing first EDL time

Post by jason_ruz »

Hi,
I'm using the following settings to get both an EDL file and an XML file for comparison:

Code: Select all

output_edl=1
output_dvrmstb=1
When you look in the EDL file it has the following values:

Code: Select all

0.00	183.44	0
871.16	961.12	0
1412.36	1502.20	0
1904.12	2021.44	0
2154.24	2154.28	0
When you look in the XML file it is missing the first value from the EDL list:

Code: Select all

<?xml version="1.0" encoding="utf-8" ?>
<root>
  <commercial start="871.160000" end="961.120000" />
  <commercial start="1412.360000" end="1502.200000" />
  <commercial start="1904.120000" end="2021.440000" />
  <commercial start="2154.240000" end="2154.280000" />
 </root>
I was expecting that the XML file would have the same times as the EDL file, so there should be an extra commercial line at the beginning that says this:

Code: Select all

<commercial start="0.000000" end="183.440000" />
Can you please change the XML file output so that it includes that first missing line?

Thanks,
Jason
erik
Site Admin
Posts: 3369
Joined: Sun Aug 21, 2005 3:49 pm

Re: XML times missing first EDL time

Post by erik »

I found the problem and it will be solved in build 129, due for release this week
erik
Site Admin
Posts: 3369
Joined: Sun Aug 21, 2005 3:49 pm

Re: XML times missing first EDL time

Post by erik »

Could you test build 129?
jason_ruz
Posts: 8
Joined: Fri Dec 22, 2006 3:34 am

Re: XML times missing first EDL time

Post by jason_ruz »

Where is it? I can't find build 129 in the download section: http://www.kaashoek.com/files/
erik
Site Admin
Posts: 3369
Joined: Sun Aug 21, 2005 3:49 pm

Re: XML times missing first EDL time

Post by erik »

Will be there later today, had a bug in the release procedure......
jason_ruz
Posts: 8
Joined: Fri Dec 22, 2006 3:34 am

Re: XML times missing first EDL time

Post by jason_ruz »

Nope, using 79.129 and the XML file still isn't showing up the first time properly. Here's the output from another file:

EDL:

Code: Select all

0.00	182.48	0
703.12	838.24	0
1311.20	1498.12	0
1791.36	1946.96	0
2033.28	2076.76	0
2217.52	2217.56	0
XML:

Code: Select all

<?xml version="1.0" encoding="utf-8" ?>
<root>
  <commercial start="703.120000" end="838.240000" />
  <commercial start="1311.200000" end="1498.120000" />
  <commercial start="1791.360000" end="1946.960000" />
  <commercial start="2033.280000" end="2076.760000" />
  <commercial start="2217.520000" end="2217.560000" />
 </root>
erik
Site Admin
Posts: 3369
Joined: Sun Aug 21, 2005 3:49 pm

Re: XML times missing first EDL time

Post by erik »

You are right. :oops:
I corrected in build 132. Can you test again?
jason_ruz
Posts: 8
Joined: Fri Dec 22, 2006 3:34 am

Re: XML times missing first EDL time

Post by jason_ruz »

79.132 is working great. :D Thank you Erik!
jens
Posts: 8
Joined: Tue Jul 08, 2008 10:59 pm

Re: XML times missing first EDL time

Post by jens »

Erik,

I'm posting here as the bug seems related. I get the below "edl", "edlx" and "dvrmstb" outputs from Comskip 0.79.142. I would expect 5 inclusions (as in the dvrmstb file), but the edl and edlx flavours have only 4. The interesting part is the negative start value of the first exclusion in the dvrmstb file.

Code: Select all

756.40	1062.24	0
1668.28	1956.28	0
2673.40	2977.24	0
3560.60	3715.60	0

Code: Select all

<regionlist units="bytes" mode="exclude"> 
<region start="269317197" end="348354811"/> 
<region start="581319669" end="675140843"/> 
<region start="950118407" end="1035259315"/> 
<region start="1269266465" end="1309956687"/> 
</regionlist>

Code: Select all

<?xml version="1.0" encoding="utf-8" ?>
<root>
  <commercial start="-0.960000" end="155.280000" />
  <commercial start="756.400000" end="1062.240000" />
  <commercial start="1668.280000" end="1956.280000" />
  <commercial start="2673.400000" end="2977.240000" />
  <commercial start="3560.600000" end="3715.600000" />
 </root>
erik
Site Admin
Posts: 3369
Joined: Sun Aug 21, 2005 3:49 pm

Re: XML times missing first EDL time

Post by erik »

Could you mail me the .csv file and the log file with verbose=10 as I am not able to reproduce the problem with my test files.
jens
Posts: 8
Joined: Tue Jul 08, 2008 10:59 pm

Re: XML times missing first EDL time

Post by jens »

Erik, I don't have the log files anymore. I think you can repro this with a show that has commercials or a previous show right at the start and a padding= value somewhat larger than 0.
erik
Site Admin
Posts: 3369
Joined: Sun Aug 21, 2005 3:49 pm

Re: XML times missing first EDL time

Post by erik »

None of my test files do show this problem.
Is this after manual reviewing and editing?
Or after a normal comskip run?
jens
Posts: 8
Joined: Tue Jul 08, 2008 10:59 pm

Re: XML times missing first EDL time

Post by jens »

it was remove_before= ;)

with a commercial right at the beginning, the XML file generated by output_dvrmstb=1 has a negative value for the first cut block, and all EDL variants simply drop the first cut block. Log file and cut lists sent by private email.

The solution is probably to constrain all blocks to [0.0s; total length of the recording].
erik
Site Admin
Posts: 3369
Joined: Sun Aug 21, 2005 3:49 pm

Re: XML times missing first EDL time

Post by erik »

Thanks for the help.
Will be solved in build 143 due today
Post Reply