after_logo=999 feature does not work an logo disappearing

Where all the bugs are reported and discussed
Post Reply
h123
Posts: 7
Joined: Tue Feb 03, 2009 1:50 am

after_logo=999 feature does not work an logo disappearing

Post by h123 »

Hi

I have set both after_logo and before_logo to 999. Cutpoints are only set on logo appearing.

Thanks
ozzie Greg
Posts: 1
Joined: Wed Feb 11, 2009 12:05 am

Re: after_logo=999 feature does not work an logo disappearing

Post by ozzie Greg »

I have noticed the same issue. With just detect_method=2 (logo) with or without the after_logo don't seem to work at 80.012. The detection seems to be working fine, its the decision to put a cut point that has gone mising. I have also noticed the "volume of -1" as mentioned elsewhere is not being used to help detect cut points
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: after_logo=999 feature does not work an logo disappearing

Post by erik »

This should be solved in build 0.80.013 being release as I am writing this
h123
Posts: 7
Joined: Tue Feb 03, 2009 1:50 am

Re: after_logo=999 feature does not work an logo disappearing

Post by h123 »

The problem is NOT :( resolved for me. Still same behaviour.
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: after_logo=999 feature does not work an logo disappearing

Post by erik »

The before/after logo cuts do NOT happen if the distance till the next logo block is less then 1/4 of the max_commercial_break
h123
Posts: 7
Joined: Tue Feb 03, 2009 1:50 am

Re: after_logo=999 feature does not work an logo disappearing

Post by h123 »

Ok I try it. But i like the other heuristics very much, why should I play with other parameters in order to only get the one thing -> cutpoints when logo disappearing.

So my suggestion. Would it be a bad idea to introduce an extra switch?

cutpoint_on_logoswitch= 1

which get the wanted behavior. The "hack" with the after_logo=999 wouldn't than be needed.

Thanks
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: after_logo=999 feature does not work an logo disappearing

Post by erik »

The rule to add a cutpoint when logo (dis)appears without paying attention to the sound level is a bad approach.
In general it creates more problems then it solves.
Just imagine your broadcaster has some kind of promotion and inserts a moving logo during the last couple of seconds of the show.
You will lose that part of the show.
h123
Posts: 7
Joined: Tue Feb 03, 2009 1:50 am

Re: after_logo=999 feature does not work an logo disappearing

Post by h123 »

Hi again

Even if the criteria max_commercial_break is fullfilled it does not work. I have sent you an zip archive.

Thanks
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: after_logo=999 feature does not work an logo disappearing

Post by erik »

Will have a look tonight
h123
Posts: 7
Joined: Tue Feb 03, 2009 1:50 am

Re: after_logo=999 feature does not work an logo disappearing

Post by h123 »

Hi Erik
erik wrote:The rule to add a cutpoint when logo (dis)appears without paying attention to the sound level is a bad approach.
In general it creates more problems then it solves.
Just imagine your broadcaster has some kind of promotion and inserts a moving logo during the last couple of seconds of the show.
You will lose that part of the show.
You are right. BUT ... :wink:

I do not seek for a comskip.ini that is good for all kinds of recordings
My actual application is a TV series. I record one episode each day. The way in which the logo is overladed and other things does not change from day to day. I would really like to be able to tune comskip in such a way, that I do not have to review its results, but to automate the encoding/cutting process.

In the case it would be perfect if comskip would cut whenever the logo appears or disappears. And thats why I am asking for it.

Thanks

PS. Should we move this topic to feature requests?
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: after_logo=999 feature does not work an logo disappearing

Post by erik »

Did you test the latest build?
Does it work?
Post Reply