play_nice could play nicer

Where all the user feedback and suggestions for improvements go
Post Reply
LastButNotLeast
Posts: 39
Joined: Tue Jan 31, 2012 12:13 am

play_nice could play nicer

Post by LastButNotLeast »

With play_nice_sleep set to 0, Comskip processes a file in about 10 minutes but uses 80% to 90% of CPU. Set to any non-zero integer, CPU use drops to about 5% and processing takes about an hour.
Something in between would be nice.
:wink:

erik
Site Admin
Posts: 3338
Joined: Sun Aug 21, 2005 3:49 pm

Re: play_nice could play nicer

Post by erik »

On what CPU?

LastButNotLeast
Posts: 39
Joined: Tue Jan 31, 2012 12:13 am

Re: play_nice could play nicer

Post by LastButNotLeast »

Celeron G530
http://www.costcentral.com/proddetail/I ... OgodqG0AWQ

Edit, after further testing:
=1 takes about 47 minutes
=-1 takes just about an hour
=5 takes just about an hour
=10 takes just about an hour
=100 would probably take most of the rest of my life.

Fractions of 1 just round down to 0, so my current options seem to be (as I originally postulated) 10 minutes at 85% or 50 minutes at 5%.
Something in between would be ideal.

LastButNotLeast
Posts: 39
Joined: Tue Jan 31, 2012 12:13 am

Re: play_nice could play nicer

Post by LastButNotLeast »

Any hope of allowing a play_nice_sleep = 0.5 in the future?

erik
Site Admin
Posts: 3338
Joined: Sun Aug 21, 2005 3:49 pm

Re: play_nice could play nicer

Post by erik »

Nope,
Can't sleep shorter then a millisecond on windows for the moment.

LastButNotLeast
Posts: 39
Joined: Tue Jan 31, 2012 12:13 am

Re: play_nice could play nicer

Post by LastButNotLeast »

Somehow, you fixed it anyway. :)
I missed a few, but just updated to 059. As you suggest, I ran it first with the default config file. It took about 8 minutes and used 90% to 95% of the CPU.
I then put in my play_nice code and it took about 45 minutes and used almost no CPU.
But setting play_nice_sleep = 0 now takes about 15 minutes with CPU usage between 45% and 50%.
PERFECT. :D
Many thanks again for your amazing efforts on this.
Michael

Post Reply