Comskip Support Forum

Comskip is a free commercial detector, browse the forum for more information
It is currently Mon May 20, 2013 2:05 am

All times are UTC [ DST ]




Post new topic Reply to topic  [ 5 posts ] 
Author Message
PostPosted: Wed Jun 10, 2009 12:34 pm 
Offline

Joined: Wed Jun 10, 2009 12:32 pm
Posts: 3
It seems remove_before and remove_after work fine as long as they are whole numbers, but if you enter 0.5, it's the same as entering 0.

Any chance for a fix?

Thanks.


Top
 Profile  
 
PostPosted: Wed Jun 10, 2009 12:38 pm 
Offline

Joined: Wed Jun 10, 2009 12:32 pm
Posts: 3
I confirmed it in comskip.c:

Code:
if ((tmp = FindNumber(data, "remove_before=", (double) remove_before)) > -1) remove_before = (int)tmp;


Any estimate on when a new fix and build might be out?


Top
 Profile  
 
PostPosted: Wed Jun 10, 2009 6:17 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 2438
Could you elaborate why you need fractional numbers?


Top
 Profile  
 
PostPosted: Thu Jun 11, 2009 2:18 pm 
Offline

Joined: Wed Jun 10, 2009 12:32 pm
Posts: 3
In Japan, they don't have black frames, or a pause in sound. All I have to go off is aspect ratio and a logo. No matter how I try tuning it, there are always exactly 4 frames of commercial in the show block I would like to trim out by using remove_before=0.1334. I suppose I could use a full second and risk trimming some of the show. I guess I don't see the need to cast the double back to an int.

Thanks for reading.


Top
 Profile  
 
PostPosted: Thu Jun 11, 2009 3:03 pm 
Offline
Site Admin

Joined: Sun Aug 21, 2005 3:49 pm
Posts: 2438
That is a good reason.
I will implement if you can send me at least two examples of the input requested in the "how to ask for help"topic as I like to have some japanese test files.
I can use the test file to test the implementation


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group