81_93_donators and newer srt output broken

Where all the bugs are reported and discussed
Post Reply
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

81_93_donators and newer srt output broken

Post by dp250f » Sat Mar 04, 2017 7:42 pm

When analyzing mkv files created with Plex DVR and HDHomeRun Prime (not copy protected, US broadcast channels) donator's versions81_93 and 81_94 no longer output srt files from the closed captioning information. It works fine in version 81_92_donators.

If you need sample video files, let me know.

McGuyver
Posts: 10
Joined: Fri Oct 25, 2013 6:39 am

Re: 81_93_donators and newer srt output broken

Post by McGuyver » Wed Apr 19, 2017 9:38 pm

https://github.com/erikkaashoek/Comskip ... 028998444e

that commit ended up changing the output name of the srt file to smi

erik
Site Admin
Posts: 3297
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik » Tue Apr 25, 2017 8:46 pm

Corrected
Should be ok now in build 95

dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f » Sat May 13, 2017 7:48 pm

Thanks for looking into it. I tried build 97 and it does output srt files again.

The problem now is it never outputs more than 3 minutes worth of subtitles. In the SRT file, they stop usually between 50 seconds and 3 minutes into the show. EDL files seem to work normally still, so it is still scanning the whole file.

Thanks.

erik
Site Admin
Posts: 3297
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik » Sun May 14, 2017 12:30 pm

Probably stops after finding logo.
Can you check?

dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f » Sun May 14, 2017 5:29 pm

That does appear to be what's happening.
Here's a OneDrive url to the log and srt file of an example recording scan:
https://1drv.ms/f/s!AvNhAUP7bUAto5ZzTr8BpqCnyBHeIw
It is valid for 30 days.

erik
Site Admin
Posts: 3297
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik » Mon May 15, 2017 5:14 pm

Thanks

McGuyver
Posts: 10
Joined: Fri Oct 25, 2013 6:39 am

Re: 81_93_donators and newer srt output broken

Post by McGuyver » Mon May 15, 2017 11:32 pm

I don't know why it works, but doing this fixes the problem for me on Win XP.

Code: Select all

@@ -9355,7 +9355,7 @@ FILE* LoadSettings(int argc, char ** argv)
     if (!loadingTXT && (output_srt || output_smi ))
     {
 #ifdef PROCESS_CC
-        char filename[MAX_PATH];
+        //char filename[MAX_PATH];
         char *CEW_argv[10];
         i = 0;
         CEW_argv[i++] = "comskip.exe";

dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f » Thu Aug 03, 2017 2:02 am

Any news on this? I'm excited to try a newer version.

Thanks for all your hard work.

erik
Site Admin
Posts: 3297
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik » Thu Aug 03, 2017 12:20 pm

I was assuming it was fixed. Its not?

dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f » Sat Aug 05, 2017 8:43 pm

No, it stops processing subtitles when it finds the logo.

erik
Site Admin
Posts: 3297
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik » Mon Aug 07, 2017 7:25 am

Will look into it

dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f » Tue Aug 08, 2017 2:17 am

Thanks! If you need a sample recording / comskip.ini, or any other files, let me know.

erik
Site Admin
Posts: 3297
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik » Sat Aug 12, 2017 12:21 pm

Found the problem and will be solved in the next release 0.82.001, later today

dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f » Tue Aug 15, 2017 1:02 am

I have confirmed srt output works as expected now. Thanks for all the work you do on this - I appreciate it.

Post Reply