81_93_donators and newer srt output broken

Where all the bugs are reported and discussed
Post Reply
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

81_93_donators and newer srt output broken

Post by dp250f »

When analyzing mkv files created with Plex DVR and HDHomeRun Prime (not copy protected, US broadcast channels) donator's versions81_93 and 81_94 no longer output srt files from the closed captioning information. It works fine in version 81_92_donators.

If you need sample video files, let me know.
McGuyver
Posts: 10
Joined: Fri Oct 25, 2013 6:39 am

Re: 81_93_donators and newer srt output broken

Post by McGuyver »

https://github.com/erikkaashoek/Comskip ... 028998444e

that commit ended up changing the output name of the srt file to smi
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik »

Corrected
Should be ok now in build 95
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f »

Thanks for looking into it. I tried build 97 and it does output srt files again.

The problem now is it never outputs more than 3 minutes worth of subtitles. In the SRT file, they stop usually between 50 seconds and 3 minutes into the show. EDL files seem to work normally still, so it is still scanning the whole file.

Thanks.
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik »

Probably stops after finding logo.
Can you check?
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f »

That does appear to be what's happening.
Here's a OneDrive url to the log and srt file of an example recording scan:
https://1drv.ms/f/s!AvNhAUP7bUAto5ZzTr8BpqCnyBHeIw
It is valid for 30 days.
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik »

Thanks
McGuyver
Posts: 10
Joined: Fri Oct 25, 2013 6:39 am

Re: 81_93_donators and newer srt output broken

Post by McGuyver »

I don't know why it works, but doing this fixes the problem for me on Win XP.

Code: Select all

@@ -9355,7 +9355,7 @@ FILE* LoadSettings(int argc, char ** argv)
     if (!loadingTXT && (output_srt || output_smi ))
     {
 #ifdef PROCESS_CC
-        char filename[MAX_PATH];
+        //char filename[MAX_PATH];
         char *CEW_argv[10];
         i = 0;
         CEW_argv[i++] = "comskip.exe";
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f »

Any news on this? I'm excited to try a newer version.

Thanks for all your hard work.
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik »

I was assuming it was fixed. Its not?
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f »

No, it stops processing subtitles when it finds the logo.
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik »

Will look into it
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f »

Thanks! If you need a sample recording / comskip.ini, or any other files, let me know.
erik
Site Admin
Posts: 3368
Joined: Sun Aug 21, 2005 3:49 pm

Re: 81_93_donators and newer srt output broken

Post by erik »

Found the problem and will be solved in the next release 0.82.001, later today
dp250f
Posts: 7
Joined: Sat Mar 04, 2017 7:33 pm

Re: 81_93_donators and newer srt output broken

Post by dp250f »

I have confirmed srt output works as expected now. Thanks for all the work you do on this - I appreciate it.
Post Reply