remove_before and remove_after can't take floats

[flight16]

It seems remove_before and remove_after work fine as long as they are whole numbers, but if you enter 0.5, it's the same as entering 0.

Any chance for a fix?

Thanks.

[flight16]

I confirmed it in comskip.c:

Code: Select all

if ((tmp = FindNumber(data, "remove_before=", (double) remove_before)) > -1) remove_before = (int)tmp;

Any estimate on when a new fix and build might be out?

[erik]

Could you elaborate why you need fractional numbers?

[flight16]

In Japan, they don't have black frames, or a pause in sound. All I have to go off is aspect ratio and a logo. No matter how I try tuning it, there are always exactly 4 frames of commercial in the show block I would like to trim out by using remove_before=0.1334. I suppose I could use a full second and risk trimming some of the show. I guess I don't see the need to cast the double back to an int.

Thanks for reading.

[erik]

That is a good reason.
I will implement if you can send me at least two examples of the input requested in the "how to ask for help"topic as I like to have some japanese test files.
I can use the test file to test the implementation